test(crypto): flip stale subtle.encrypt rejection assertion to compile-success#958
Merged
Merged
Conversation
…e-success PR #952 added AES-GCM (and AES-CBC routing) support to crypto.subtle.encrypt, but the matching test in crates/perry-hir/tests/unimplemented_api_check.rs still asserted rejection. The test was failing on every PR rebased onto main since #952 landed. Inverts the assertion: the test now exercises the modern compile-success path so a regression in the lowering would still surface.
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #952 added AES-GCM support (and AES-CBC routing) to
crypto.subtle.encrypt, but the matching test incrates/perry-hir/tests/unimplemented_api_check.rs::crypto_subtle_encrypt_is_rejectedstill asserted the call should be rejected. The test was failing on every PR rebased onto main since #952 landed (visible on #941, #944, #947, #951, #953, #956, #957).Inverts the assertion: the test now exercises the modern compile-success path so a regression in the lowering would still surface here.
cargo test -p perry-hir --test unimplemented_api_check— 10 tests pass.