docs: regenerate API reference + .d.ts to match manifest#1003
Merged
Conversation
PRs #966, #967, #982, #984 added entries to perry-api-manifest::API_MANIFEST (stream EventEmitter instance methods, stream.prototype, lodash inRange/max/maxBy/mean/meanBy/min/minBy/random/sum/sumBy/tail) without rerunning ./scripts/regen_api_docs.sh. Drift has been blocking the api-docs-drift gate on every subsequent PR; unblocking the next batch. Coverage moves from 870 → 898 entries across 71 modules. Mechanical regen, no manifest edits.
This was referenced May 18, 2026
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…1009) PR #973 lowered bare built-in idents (`Promise`, `Array`, `Date`, ...) as `PropertyGet { GlobalGet(0), name }` so they route through the globalThis singleton closure path. Two codegen call sites that specialize `.then()` dispatch were still pattern-matching the legacy `Expr::GlobalGet(_)` shape only: - `type_analysis::is_promise_expr` for `Promise.resolve/reject/all/race/ allSettled/any(...)` and `Array.fromAsync(...)`. - `lower_call.rs`'s fused `Promise.resolve(x).then(cb)` fast path that routes to `js_promise_resolved_then`. When `is_promise_expr` returned false, `.then(cb)` fell through to the generic native method dispatch which doesn't enqueue the callback — microtask-02..07 and edge-promises went silent in compile-smoke's Native no-fallback gate, and on Linux V8 surfaced the same shape as `TypeError: then is not a function`. The Native gate had been red on every PR since #973 (admin-bypassed on #997 / #1000 / #1003 / #1004). Extract `type_analysis::is_global_builtin_named(expr, name)` that matches both shapes (legacy `GlobalGet(_)` and the post-#973 `PropertyGet { GlobalGet(0), name }`) and route both call sites through it. Validation: `scripts/run_native_no_fallback_tests.sh` — 35 passed, 0 failed (was 28/7 pre-fix).
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRs #966, #967, #982, and #984 added entries to
perry-api-manifest::API_MANIFEST(stream EventEmitter instancemethods,
stream.prototype, lodashinRange/max/maxBy/mean/meanBy/min/minBy/random/sum/sumBy/tail)but didn't rerun
./scripts/regen_api_docs.sh. Theapi-docs-driftgate has been red on every PR that lands on top — including #947, which
doesn't touch the manifest at all. This is the same shape of stale-on-main
blocker that #958 cleared for
cargo-testearlier.Mechanical regen, no manifest edits.
docs/api/perry.d.ts,docs/src/api/reference.md.Test plan
./scripts/regen_api_docs.shis idempotent: re-running on this branch produces no further diff.api-docs-driftjob on feat(security): #499 — gateperry-jsruntimebehind explicit host opt-in #947 reported (26 +,33 +,2 -).