Skip to content

Fix index tracking in AddTemporaryProfile() if existingProfile != null #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RisaDev merged 1 commit into from
May 17, 2026
Merged

Fix index tracking in AddTemporaryProfile() if existingProfile != null #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CustomizePlus/Profiles/ProfileManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,6 @@ public void AddTemporaryProfile(Profile profile, Actor actor)
profile.Enabled = true;
profile.ProfileType = ProfileType.Temporary;
profile.Priority = int.MaxValue; //Make sure temporary profile is always at max priority
profile.Index = Profiles.Count;

var permanentIdentifier = identifier.CreatePermanent();
profile.Characters.Clear();
Expand All @@ -453,6 +452,7 @@ public void AddTemporaryProfile(Profile profile, Actor actor)
DeleteProfile(existingProfile);
}

profile.Index = Profiles.Count; // capture index *after* potential DeleteProfile() above
Profiles.Add(profile);

_logger.Debug($"Added temporary profile for {permanentIdentifier}");
Expand Down
Loading