Fix index tracking in AddTemporaryProfile() if existingProfile != null#110
Merged
Merged
Conversation
Every profile in `Profiles` has an `.Index` that points back to its position in `Profiles`. DeleteProfile() requires that the .Index match the position (`Profiles[profiles.Index] == profile`). AddTemporaryProfile() set .Index = Profiles.Count on the new temporary profile, but it did so *before* deleting any existing profile. This led to the .Index being off by one, so subsequent DeleteProfile() calls would `return false`. Reproduction steps: 1. Enable debug logging and debug mode for C+ 1. In the IPC tester, copy current profile into memory 1. SetTemporaryProfileOnCharacter from memory 1. DeleteTemporaryProfileOnCharacter -> observe the "Removed temporary profile" log line 1. SetTemporaryProfileOnCharacter from memory 1. (Again) SetTemporaryProfileOnCharacter from memory 1. DeleteTemporaryProfileOnCharacter -> observe no "Removed temporary profile" log
Member
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every profile in
Profileshas an.Indexthat points back to its position inProfiles. DeleteProfile() requires that the .Index match the position (Profiles[profiles.Index] == profile).AddTemporaryProfile() set .Index = Profiles.Count on the new temporary profile, but it did so before deleting any existing profile. This led to the .Index being off by one, so subsequent DeleteProfile() calls would
return false.Reproduction steps: