fix: 修复打完boss不回血的问题 restore HP between acts using original game formula#83
Open
tianyumyum wants to merge 1 commit into
Open
fix: 修复打完boss不回血的问题 restore HP between acts using original game formula#83tianyumyum wants to merge 1 commit into
tianyumyum wants to merge 1 commit into
Conversation
In the real game, AncientEventModel.BeforeEventStarted heals the player between acts. In headless mode, Godot transition callbacks are no-oped so this never fires. Replicate the exact formula from sts2.dll IL: healAmount = MaxHp - CurrentHp if Ascension >= 2: healAmount *= 0.8 This matches the game engine behavior including the Ascension 2+ penalty. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In headless mode, player HP is not restored when transitioning between acts. After
defeating the Act 1 Boss, the player enters Act 2 with the same HP instead of being healed.
Example from game log:
Root Cause
Between-act healing is handled by
AncientEventModel.BeforeEventStarted, which istriggered via Godot transition callbacks during the act transition animation. In headless
mode, GodotStubs no-ops these callbacks, so the healing never fires.
Fix
Add
HealBetweenActs()after bothEnterNextAct()call sites, replicating the originalformula from the game engine IL: