fix: target player for AnyPlayer potions#54
Open
Julian-Moncarz wants to merge 1 commit into
Open
Conversation
119be27 to
1053d44
Compare
1053d44 to
62b8df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
AnyPlayerpotions so the headless CLI targets the player creature when constructingUsePotionAction.Before this change, an
AnyPlayerpotion such as Liquid Bronze could be consumed without applying its player-targeted effect. In the regression test, Liquid Bronze disappears from the potion list but no Thorns power is added.Changes
TargetType.AnyPlayerlike other player-targeting potion types inDoUsePotion.idfields to serialized player potions and player/enemy powers, so tests and downstream agents do not need localized display names.p3, selecting Phial Holster by its stabletext_key.LIQUID_BRONZE, and verifies the player gainsTHORNS_POWER.Tests
Red before the fix:
Green after the fix:
Note:
tests/test_card_reward.py::TestCardReward::test_skip_cardandtests/test_rest_site.py::TestRestSiteActions::test_heal_caps_at_maxfail on clean upstream with my current game DLLs as well, so I excluded them from the broader validation run.