docs(agent-platform): add agent identities page and expand secrets + web-UI coverage#88
docs(agent-platform): add agent identities page and expand secrets + web-UI coverage#88hongyi-chen wants to merge 3 commits into
Conversation
…ed pages Adds a new dedicated page for named agents (agent identities) under cloud agents, and reconciles a handful of existing pages so that automation guidance and service-account references point to the new page. - New: src/content/docs/agent-platform/cloud-agents/agents.mdx — what a named agent is, plan limits, attaching descriptions/secrets/skills, REST endpoints, API keys bound to a named agent, running as a specific identity, and where named agents surface in the product. - Edit: agent-platform/cloud-agents/secrets.mdx — forward-links from the team-secrets recommendation and adds a brief note that secrets can be attached directly to a named agent. - Edit: agent-platform/cloud-agents/deployment-patterns.mdx — Pattern 1 checklist now references a named agent (recommended for automation) instead of an unscoped "service account". - Edit: agent-platform/cloud-agents/oz-web-app.mdx — reconciles the two meanings of the Agents page (skills browser + named-agent management) with a clear section split and a forward link. - Edit: reference/cli/index.mdx — keeps the literal `oz whoami` output intact and adds a one-line note pointing readers to the new agents page for what a service-account principal represents. - Edit: reference/cli/federate.mdx — keeps the literal `service_account:my-sa-id` example and adds a cross-reference to the new agents page. Hard rules: no edits to sidebar.ts, vercel.json, landing pages, or any pages owned by the five orchestration-launch PRs. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a new named agents reference page and cross-links it from related cloud agent, secrets, and CLI docs. The structure is useful, but several changed lines currently document API/UI behavior that conflicts with the generated API reference or with other new text in the same PR.
Concerns
- The named agents page advertises create/update fields and a retrieve endpoint that are not present in the generated public API reference.
- The page gives conflicting guidance on whether the fallback/Quick run identity is the default named agent or the calling user.
- The web app page promises default model/harness/default configuration on named agents, but the new reference and API schema do not document those fields.
Verdict
Found: 0 critical, 4 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| The endpoints behave as follows: | ||
|
|
||
| * **Create** - `POST /agent/identities` with a `name` and optional `description`, `secrets`, and `skills`. Returns `201` with the new agent's `uid`, `name`, and `available` flag. |
There was a problem hiding this comment.
CreateAgentRequest and UpdateAgentRequest currently only include name, and AgentResponse only returns uid, name, available, and created_at. Either sync the API schema/server support in this PR or remove description, secrets, and skills from the endpoint docs.
|
|
||
| * **Create** - `POST /agent/identities` with a `name` and optional `description`, `secrets`, and `skills`. Returns `201` with the new agent's `uid`, `name`, and `available` flag. | ||
| * **List** - `GET /agent/identities` returns every named agent on the team, including the default. Each entry includes an `available` flag indicating whether it is within the plan limit. | ||
| * **Retrieve** - `GET /agent/identities/{uid}` returns a single agent by its UID. |
There was a problem hiding this comment.
GET /agent/identities/{uid} is not present in the API reference; that path currently only defines PUT and DELETE, so readers will look for a getAgent operation that does not exist. Add the operation to the public spec or remove this Retrieve bullet.
| * **Authenticate with a key bound to the agent** - Every run started with that key executes as the bound named agent. This is the typical path for CI pipelines and scheduled work. | ||
| * **Pass `agent_identity_uid` on `POST /agent/runs`** - For one-off runs, send the named agent's `uid` in the request body. The field is only valid for team-owned runs. | ||
|
|
||
| When neither path is used, runs execute under the default identity ("Quick run" in the web app). |
There was a problem hiding this comment.
oz-web-app.mdx, which say Quick run runs as the calling user. Resolve whether the fallback is the default named agent or the user's identity before publishing.
|
|
||
| Named agents are managed from the same Agents page. From the named-agents view, you can: | ||
|
|
||
| * **Create a named agent** - Give it a name, an optional description, a default model and harness, and the secrets and skills runs as that agent should receive. |
There was a problem hiding this comment.
…web-UI coverage Revises the previous "named agents" page and related cross-links to use "agent identity" consistently, and folds in three product surfaces that land alongside agent identities at launch. - agents.mdx: retitled to "Agent identities" and reframed throughout to use the canonical term. Plan-limit table replaced with a single sentence pointing readers to warp.dev/pricing while preserving the default-identity / over-limit visibility behavior. Adds two new subsections: a service-account-to-agent-identity mapping (covers service_account:<uid> in oz whoami and oz federate) and a rationale paragraph for supporting multiple identities (CI, on-call, scheduled jobs). - secrets.mdx: new "Creating secrets in the Oz web app" walkthrough alongside the existing oz secret CLI section. New "Scoping secrets to environments and runs" section covering environment-level scoping and run-level scoping (default-inherit / explicit list / empty-list opt-out), with cross-links to environments and the Oz API reference. Terminology references updated. - oz-web-app.mdx: adds Secrets to the quick-reference table, reframes the Agents-page disambiguation to use "agent identity," and adds a step-by-step walkthrough of the New agent side pane (name, description, prompt, skills, harness, model, harness auth secret, secrets, memory stores). Cross-links to agents.mdx for the conceptual reference. - deployment-patterns.mdx: Pattern 1 checklist now references "an agent identity." - reference/cli/index.mdx and reference/cli/federate.mdx: leave literal CLI output intact; one-line notes tying service_account principals to agent identities, with cross-links to agents.mdx. Co-Authored-By: Oz <oz-agent@warp.dev>
|
Revision pass pushed (2b7552a). Summary of what changed since the initial commit: Terminology
agents.mdx
secrets.mdx
oz-web-app.mdx
Files touched (all in scope)
Validation
Open questions for product / PM
|
Pre-existing grammar slips picked up during the agent-identities PR audit. 'Cloud' starts with a consonant sound, so the article 'a' is correct. Co-Authored-By: Oz <oz-agent@warp.dev>
Summary
Dedicated docs PR for agent identities (named agents) under cloud agents. Separate from the five in-flight orchestration-launch PRs, targeting the same gating branch
hyc/orchestration-launch.The PR adds one new page covering what a named agent is, plan limits, attached configuration (description, managed secrets, skills), CRUD via the public REST API, API keys bound to a specific identity, running as a named agent, and where named agents surface across the product. It also reconciles a handful of existing pages so service-account and automation references forward-link to the new page without renaming "service account" everywhere it appears.
New page
src/content/docs/agent-platform/cloud-agents/agents.mdx— Named agents reference. Title: Named agents. Sidebar label:Named agents. Covers: what a named agent is, default vs. additional identities, plan limits per plan name (Free / Build / Business / Enterprise), attached description / managed secrets / skills, create / list / update / delete via REST (with a pointer to the OpenAPI page at/api), generating an API key bound to an identity, running as a specific identity (key binding oragent_identity_uidonPOST /agent/runs), and where identities surface (Agents page, Agent picker, Run filters, Admin Panel). Caveats: team-scoped, user must be on exactly one team, over-plan-limit identities are visible but unusable.Edited pages
src/content/docs/agent-platform/cloud-agents/secrets.mdx— Adds a forward link to the new agents page in the team-secrets recommendation and a brief note that secrets can be attached directly to a named agent. Keeps "service account" intact where it refers to external systems (Metabase, GCP, etc.).src/content/docs/agent-platform/cloud-agents/deployment-patterns.mdx— Pattern 1 setup checklist:A service account (recommended for automation)→A named agent (recommended for automation)with a link to the new agents page.src/content/docs/agent-platform/cloud-agents/oz-web-app.mdx— Reconciles the two meanings of the/agentsURL by splitting the Agents section into clearly-separated Skills and Named agents subsections, with a forward link to the new agents page for the full reference. Renames the in-page "Creating new agents" → "Creating new skills" so the skills/named-agents distinction is unambiguous within the page. Adds aNamed agentsentry to the related-resources footer.src/content/docs/reference/cli/index.mdx— Leaves the literaloz whoamioutput text intact (user or service account ID) and adds a one-line note that a service-account principal is a named agent on your team, linking forward to the new agents page.src/content/docs/reference/cli/federate.mdx— Keeps the literalservice_account:my-sa-idexample in the subject-template components reference and adds a one-line cross-reference to the new agents page.Out of scope
src/sidebar.ts,vercel.json, top-level landing pages, or any files owned by the five in-flight launch PRs (harnesses/*,orchestration/*,handoff/*,agent-memory/*,platform-credits.mdx,multi-agent-editedfiles,cli-agents/*multi-harness files). The sidebar entry for the new page will be added in a separate follow-up.Validation
python3 .agents/skills/style_lint/style_lint.py— Run directly against the 6 changed files: 0 issues.python3 .agents/skills/check_for_broken_links/check_links.py --internal-only— Run directly against the 6 changed files: 92 internal links checked, 0 broken.Open questions for product / PM
agent_identities_apiflag per spec (PRODUCT.md). Are we shipping the docs page in lockstep with the flag flip, or should I add a brief "Available to teams on the orchestration launch wave" preamble?x-internal: true. Today the/agent/identitiesendpoints are public inwarp-server/public_api/openapi.yaml(notx-internal), so the page references the OpenAPI page at/apifor full request/response shapes. Confirm this is the intent at launch — if any of these endpoints will flip tox-internal: truebefore launch, I'll need to reframe the "Managing named agents" section.src/sidebar.tsper the hard rules. Should a sidebar entry be added before merge, or do you want this PR to land as a hidden page that's only reachable via the cross-links until the broader navigation lands?Artifacts
Co-Authored-By: Oz oz-agent@warp.dev