Improve dimension values query#2565
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mburri
requested changes
May 18, 2026
Contributor
mburri
left a comment
mburri
left a comment
There was a problem hiding this comment.
Seems to have fixed the problem.
Please fix the failing e2e and unit test, the knip task and it would be nice if you could reformat the changed files
mburri
approved these changes
May 19, 2026
Contributor
mburri
left a comment
mburri
left a comment
There was a problem hiding this comment.
looks good now, fix the e2e test and then merge it!
mburri
force-pushed
the
improve-dimension-values-query
branch
from
c29deca to
52ff2b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Dimension Values query faster. It’s now more flexible, starting with subqueries based on how many and what kind of filters you use. We’ve added a new abstract filter class and two more specific Single Filter and Multi filter classes. For each filters there a 4 kind of filters possible (literal, shared, versioned literal, versioned shared).
How to test