Update Dev by vertesy · Pull Request #34 · vertesy/Stringendo

vertesy · 2026-05-14T14:16:15Z

No description provided.

* Document and export format_number_h * ...

* Fix unsafe and inconsistent string utilities * No need for sep NA handling * regex clarified

vertesy · 2026-05-14T14:19:57Z

@copilot Could you please resolve the conflicts Intelligently ?

Copilot · 2026-05-14T14:20:02Z

@vertesy I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly.

You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

Copilot

Pull request overview

This PR is a "Update Dev" release for the Stringendo R string-manipulation package. It bumps the version to 1.1.1, refactors and renames a number of paste/collapse helpers (pnl→ppnl, knl→kpnl, new ppc), extends parsepvalue, ReplaceSpecialCharacters, and format_number_h, deprecates ifExistsElse/parFlags/flag.names_list.all.new, and updates tests, NAMESPACE, README and man pages accordingly. An older development bootstrap script is removed.

Changes:

Rename/deprecate several functions and add new helpers (ppc, ppnl, kpnl, format_number_h), with corresponding NAMESPACE and .Rd updates.
Extend behavior of parsepvalue, ReplaceSpecialCharacters, flag.names_list, plus stylistic clean-ups (F→FALSE, &→&&, brace formatting).
Add tests for format_number_h and tighten percentage_formatter tests; bump package version to 1.1.1, refresh README function list, drop legacy development script.

Reviewed changes

Copilot reviewed 13 out of 26 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
R/Stringendo.R	Core refactor: renames, new functions, behavior changes in `parsepvalue`, `ReplaceSpecialCharacters`, `flag.names_list`, deprecations.
NAMESPACE	Adds/removes exports to match renames (`ppc`, `ppnl`, `kpnl`, `format_number_h`; removes `pnl`, `knl`, `flag.names_list.all.new`).
tests/testthat/test-format_number_h.R	New tests for `format_number_h`.
tests/testthat/test-percentage_formatter.R	Update expectations to `NA_character_` and `"NaN"`.
README.md	Refresh install command and auto-generated function list.
DESCRIPTION / CITATION.cff / Development/config.R	Version bump to 1.1.1, title/metadata refresh.
man/*.Rd	Regenerated/added Rd files for renames and new/changed signatures.
Development/Create_the_Stringendo_Package.R	Minor tweaks; adds extra blank lines and absolute paths.
Development/Create_the_Stringendo_Package.OLD.R	Removed legacy bootstrap script.
.gitignore	Add `.DS_Store`.

Files not reviewed (8)

man/ReplaceSpecialCharacters.Rd: Language not supported
man/countDotOrUnderscoreSeparated.Rd: Language not supported
man/flag.names_list.Rd: Language not supported
man/format_number_h.Rd: Language not supported
man/ifExistsElse.Rd: Language not supported
man/kppc.Rd: Language not supported
man/parsepvalue.Rd: Language not supported
man/ppc.Rd: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  if (brackets) paste0("(", pv, ")") else pv
+  if (!isFALSE(prefix)) paste0(prefix, pv) else pv


  ReplaceRepeatedDots(x)
+  if (remove_dots) x <- gsub(x = x, pattern = "\\.", replacement = "") else x


           ...,
           pasteflg = TRUE,
           collapsechar = ".") {
+    .deprecated("parFlags2")


 #' @export
-parsepvalue <- function(pvalue = 0.01) paste0("(p<", pvalue, ")")
-# Parse p-value from a number to a string.
+parsepvalue <- function(pvalue = 0.01, digits = 2, brackets = F, prefix = F) {


+parsepvalue <- function(pvalue = 0.01, digits = 2, brackets = F, prefix = F) {
+  pv <- paste0("p<=", signif(pvalue, digits = digits ), "")
+  if (brackets) paste0("(", pv, ")") else pv
+  if (!isFALSE(prefix)) paste0(prefix, pv) else pv
+}


+#' #' @title flag.names_list
+#' #' @description Returns the name and value of each element in a list of parameters.
+#' #' @param par A list element e.g.: p$umap
+#' #' @examples # flag.names_list(par = p$'umap.n_neighbors')
+#' #'
+#' #' @export
+#' flag.names_list <- function(par) {
+#'   if (length(par)) paste(substitute(par), kppu(par), sep = "_")[[3]]
+#' }


 # _________________________________________________________________________________________________
 #' @title flag.names_list.all.new
 #' @description Returns the name and value of each element in a list of parameters.
-#' @param pl List of parameters, Default: p.hm
+#' @param ls List of parameters (name, value), Default: p.hm
+#' @param sep_name_val Separator name-2-value, Default: "_"
+#' @param sep_elem Separator between elements, Default: "-"
 #'
 #' @export
-flag.names_list.all.new <- function(pl = p.hm) {
-  # if (length(pl)) paste(kppu(names(pl)), kppu(pl) , sep = "_")
-  if (length(pl)) kppd(paste(names(pl), pl, sep = "_"))
+flag.names_list <- function(ls = p.hm, sep_name_val = "_", sep_elem = "-") {
+  if (length(ls))
+    paste(paste(names(ls), ls, sep = sep_name_val), collapse = sep_elem)
 }
+# flag.names_list <- function(ls = p.hm, sep_elem = "_") {
+#   if (length(ls)) kppd(paste(names(ls), ls, sep = sep_elem))
+# }

+flag.names_list.all.new <- function() .Deprecated("flag.names_list")


+#   if (length(ls)) kppd(paste(names(ls), ls, sep = sep_elem))
+# }

+flag.names_list.all.new <- function() .Deprecated("flag.names_list")


-    dot_count == 0 & usc_count == 0 & ws_count == 0 ~ "none",
-    dot_count == usc_count & dot_count == usc_count ~ "undecided"
+    dot_count == 0 && usc_count == 0 && ws_count == 0 ~ "none",
+    dot_count == usc_count && dot_count == ws_count ~ "undecided"


+      default_msg <- paste(deparse(match.call()[[i + 1]]), "is not TRUE")
+
      message <- if (!is.null(name) && nzchar(name)) {
-        paste(name, "is not TRUE")
+        paste(name, "\n", default_msg, "\n")
      } else {
-        paste(deparse(match.call()[[i + 1]]), "is not TRUE")
+        default_msg


vertesy · 2026-05-14T14:22:35Z

@copilot

The header of this pull request literally says that it is from the main to the development. Why are you concerned about the opposite happening? See below

Update Dev#34
Open
[vertesy](https://github.com/vertesy)
wants to merge 24 commits into
[dev](https://github.com/vertesy/Stringendo/tree/dev)
from
[main](https://github.com/vertesy/Stringendo/tree/main)
+359-359Lines changed: 359 additions & 359 deletions

Copilot · 2026-05-14T14:22:40Z

@vertesy I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly.

You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

vertesy · 2026-05-14T14:23:10Z

The header of this pull request literally says that it is from the main to the development. Why are you concerned about the opposite happening? See below

Update Dev#34
Open
[vertesy](https://github.com/vertesy)
wants to merge 24 commits into
[dev](https://github.com/vertesy/Stringendo/tree/dev)
from
[main](https://github.com/vertesy/Stringendo/tree/main)
+359-359Lines changed: 359 additions & 359 deletions

vertesy and others added 24 commits August 11, 2025 20:34

fix #28

eb7bf9b

Update README.md

e0fa9c4

Update .gitignore

442da8d

Use requireNamespace in toCamelCase (#31)

875db43

Document and export format_number_h (#30)

2b47dc0

* Document and export format_number_h * ...

Document and export format_number_h (#29)

6526820

rename fun ppnl and kpnl for new line paste/kollapse

2d3ac2d

fun ppc Paste by a comma followed by a white space

4a368e8

Fix unsafe and inconsistent string utilities (#32) (#33)

9303bd9

* Fix unsafe and inconsistent string utilities * No need for sep NA handling * regex clarified

...

dd2c462

...

4973e89

yearly docs update

518fdf6

...

c1cb31a

...

f28ec07

nf warnifnot Better warning message.

4f3540f

nf warnif: Better warning message.

3329824

ud flag.names_list

3ee6b3d

ud flag.names_list

a92ce6e

...

2858535

bf ReplaceSpecialCharacters now replaces control characters

1ab12bc

...

87834fe

bf ReplaceSpecialCharacters

13ca546

bf ReplaceSpecialCharacters

3d8f5ca

...

95b6240

vertesy requested a review from Copilot May 14, 2026 14:19

Copilot started reviewing on behalf of vertesy May 14, 2026 14:20 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Dev#34

Update Dev#34
vertesy wants to merge 24 commits into
devfrom
main

vertesy commented May 14, 2026

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if (brackets) paste0("(", pv, ")") else pv
		if (!isFALSE(prefix)) paste0(prefix, pv) else pv

		ReplaceRepeatedDots(x)
		if (remove_dots) x <- gsub(x = x, pattern = "\\.", replacement = "") else x

Conversation

vertesy commented May 14, 2026

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

vertesy commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants