test(core): cover cancel run spec version#2004
Open
EfeDurmaz16 wants to merge 4 commits into
Open
Conversation
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
🦋 Changeset detectedLatest commit: 2c29e6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
EfeDurmaz16
force-pushed
the
efe/test-cancel-run-spec-version
branch
from
35eb48f to
04eac55
Compare
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression coverage for
cancelRun()so Vercel-backed cancellation keeps sending arun_cancelledevent with the target run'sspecVersion. This protects the issue #1076 path where the Vercel backend rejected cancellation payloads that were missing versioned event fields.Also covers the legacy fallback path to ensure runs without a stored spec version still use the v1-compatible cancellation endpoint.
While refreshing the PR, I also fixed the Local Postgres E2E setup race visible in recent CI runs. Multiple matrix jobs were starting Graphile migrations concurrently and failing with duplicate Postgres schema / migration rows, so the Postgres queue startup now serializes Graphile migration work behind a Postgres advisory lock held on a single client.
Closes #1076.
How did you test your changes?
corepack pnpm exec vitest run packages/core/src/runtime/runs.test.tscorepack pnpm exec biome check packages/core/src/runtime/runs.test.tscorepack pnpm --filter @workflow/core typecheckcorepack pnpm exec vitest run packages/world-postgres/src/queue.test.tscorepack pnpm exec biome check packages/world-postgres/src/queue.ts packages/world-postgres/src/queue.test.tscorepack pnpm --filter @workflow/world-postgres typecheckNote:
corepack pnpm turbo run build --filter='!./workbench/*'was blocked locally by a missing Rustwasm32-unknown-unknowntarget in@workflow/swc-plugin; the targeted Postgres and core checks above pass locally.PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRpnpm changeset --emptybecause the original change is test-only.git commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is complete