Skip to content

fix(builders): decode escaped workflowCode templates#1993

Open
EfeDurmaz16 wants to merge 1 commit into
vercel:mainfrom
EfeDurmaz16:efe/fix-builders-unicode-escape-workflow-code
Open

fix(builders): decode escaped workflowCode templates#1993
EfeDurmaz16 wants to merge 1 commit into
vercel:mainfrom
EfeDurmaz16:efe/fix-builders-unicode-escape-workflow-code

Conversation

@EfeDurmaz16
Copy link
Copy Markdown

Summary

  • Decode raw workflowCode template literal quasis using the escaping produced by the builders bundle wrapper before graph extraction
  • Add a regression test for unicode-escape object identifiers like \u00C6 in bundled workflow code
  • Add a patch changeset for @workflow/builders

Closes #1958.

Verification

  • pnpm --filter @workflow/builders exec vitest run src/workflows-extractor.test.ts
  • pnpm --filter @workflow/builders typecheck
  • pnpm --filter @workflow/builders build
  • pnpm exec biome check packages/builders/src/workflows-extractor.ts packages/builders/src/workflows-extractor.test.ts .changeset/quiet-lamps-parse.md

Note: local pnpm commands warn because this machine is on Node v26.0.0 while the repo engine allows Node 18/20/22/24. Biome also reports pre-existing complexity warnings in workflows-extractor.ts; no formatting fixes remain.

@EfeDurmaz16 EfeDurmaz16 requested a review from a team as a code owner May 14, 2026 21:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

🦋 Changeset detected

Latest commit: 4358f7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@workflow/builders Patch
@workflow/astro Patch
@workflow/cli Patch
@workflow/nest Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/vitest Patch
tarballs Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch
@workflow/core Patch
@workflow/web-shared Patch
@workflow/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2026

@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
@EfeDurmaz16 EfeDurmaz16 force-pushed the efe/fix-builders-unicode-escape-workflow-code branch from 926cdde to 4358f7d Compare May 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@workflow/builders@4.0.5 crash on unicode-escape identifiers

1 participant