fix: serialize Mermaid SVG downloads#526
Open
omribz156 wants to merge 1 commit into
Open
Conversation
Contributor
|
@omribz156 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Mermaid SVG/PNG downloads when Mermaid returns HTML-serialized SVG markup containing tags like
<br>.The download path now parses the rendered markup as HTML, selects the SVG node, and serializes it with
XMLSerializerbefore saving the SVG or converting it to PNG. That keeps the browser-normalized<br>from being written back out as invalid SVG markup.Type of Change
Related Issues
Fixes #516
Changes Made
<br>markup in Mermaid SVG output.streamdown.Testing
Test Coverage
corepack pnpm build:packagescorepack pnpm --dir packages/streamdown exec vitest run __tests__/mermaid-utils.test.ts __tests__/mermaid-download.test.tsxcorepack pnpm check packages/streamdown/lib/mermaid/download-button.tsx packages/streamdown/lib/mermaid/utils.ts packages/streamdown/__tests__/mermaid-download.test.tsx packages/streamdown/__tests__/mermaid-utils.test.ts packages/streamdown/__tests__/mermaid.test.tsx .changeset/clean-walls-agree.mdcorepack pnpm --dir packages/streamdown testgit diff --checkScreenshots/Demos
Not applicable.
Checklist
pnpm changeset)Changeset
Additional Notes
Implemented with Codex assistance, with the final patch reviewed and kept focused.