fix(remend): recognize LaTeX paren and bracket math in emphasis completion#523
Open
PentaTea wants to merge 1 commit into
Open
fix(remend): recognize LaTeX paren and bracket math in emphasis completion#523PentaTea wants to merge 1 commit into
PentaTea wants to merge 1 commit into
Conversation
Treat \(...\) and \[...\] as math contexts when completing Markdown emphasis. This prevents underscores and asterisks inside LaTeX math from being counted as unclosed Markdown emphasis markers. Also update emphasis skip logic so math-context checks are not limited to dollar-delimited math. Closes vercel#522
Contributor
|
@PentaTea is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\(...\)) and bracket-style math (\[...\]) as math contexts inremend_and*inside those math contexts during emphasis completionCloses #522
Test plan
pnpm --filter remend testpnpm --filter remend buildpnpm exec ultracite check packages/remend/src/utils.ts packages/remend/src/emphasis-handlers.ts packages/remend/__tests__/katex.test.tsChangeset
remend