style: ban inline imports and hoist all use statements to module level

[devin-ai-integration]

Summary

Add a convention to REVIEW.md banning inline (function-body) use imports, and clean up all existing violations:

• REVIEW.md: New convention — all use imports must be at the top of the file or module, never inside function bodies. For test modules, imports go at the top of mod tests.
• src/api/client.rs: Hoist use std::num::NonZeroU64 from three function bodies (list_bugs, list_scans, list_repos) to file-level imports.
• src/lib.rs: Hoist use crate::api::types::BugReviewState from three test functions to the mod tests block.
• src/config/storage.rs: Hoist use std::thread from a test function to the mod tests block.

Review & Testing Checklist for Human

• Verify the REVIEW.md wording is clear and matches the team's intent
• Confirm no inline imports were missed (search for indented use in non-test code)

Notes

No clippy lint exists for banning inline imports, so this is enforced as a review convention. All existing tests (289) pass, cargo fmt --check and cargo clippy -- -D warnings are clean.

Link to Devin session: https://app.devin.ai/sessions/f68c984b82e64cb1a373f29d68cfc52e
Requested by: @sachiniyer

---

---

Summary by cubic

Banned inline use imports and hoisted all imports to the top of their file or module to standardize style and avoid hidden deps. Documented the rule in REVIEW.md and fixed all violations.

• Refactors
  • src/api/client.rs: moved std::num::NonZeroU64 imports out of three methods.
  • src/api/client.rs: hoisted mid-file use super::generated::types::CreateRuleBody and the super::types import block to the top.
  • src/lib.rs tests: moved crate::api::types::BugReviewState to mod tests.
  • src/config/storage.rs tests: moved std::thread to mod tests.

^{Written for commit d68246a. Summary will update on new commits. Review in cubic}

[devin-ai-integration]

Original prompt from Sachin

Can you add a ban against inline imports to the REVIEW.md file, then can you clean up all the inline imports and make them global imports.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[cubic-dev-ai]

No issues found across 4 files

_{Re-trigger cubic}

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

🚩 Pre-existing non-top-of-file imports in src/api/client.rs

Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.

(Refers to lines 52-58)

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.