Close the CreateTemplateServer hook gap#6
Conversation
This commit closes the hook gap where CreateTemplateServer would start the external server strategy without invoking the BeforeExternalServerStart hook. Changes: - Modified switch_mode.go to call BeforeExternalServerStart in CreateTemplateServer and handle its errors. - Updated docs/SERVER_INTERFACE.md to include CreateTemplateServer as an invocation point for the hook. - Added TestCreateTemplateServer_InvokesBeforeHook and TestCreateTemplateServer_HookErrorAbortsStart to test/before_external_hook_test.go. - Fixed a side effect in TestStartServer_InternalModeSkipsBeforeHook by using a temporary directory for AppRootDir. Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
The
CreateTemplateServermethod was identified as a separate entry point that transitions the server from internal to external mode but bypassed theBeforeExternalServerStarthook. This change ensures that the hook is invoked symmetrically across all transition paths to external mode, allowing orchestrators to flush state or prepare assets before the external binary starts.Specifically:
switch_mode.go,CreateTemplateServernow callsh.BeforeExternalServerStart()befores.Start(nil).docs/SERVER_INTERFACE.mdwas updated to reflect this.CreateTemplateServerflow.PR created automatically by Jules for task 2583130832842740185 started by @cdvelop