Skip to content

fix: skip empty open when defaults are off and keep editor raw#3382

Open
artem-harbour wants to merge 1 commit into
mainfrom
artem/SD-3153
Open

fix: skip empty open when defaults are off and keep editor raw#3382
artem-harbour wants to merge 1 commit into
mainfrom
artem/SD-3153

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented May 19, 2026

Linear: SD-3153

Prevents opening an empty context menu when includeDefaultItems: false and no custom items are available, and avoids PresentationEditor private-field proxy errors by storing context editor as markRaw.

@artem-harbour artem-harbour self-assigned this May 19, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 19, 2026

SD-3153

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@artem-harbour artem-harbour marked this pull request as ready for review May 19, 2026 13:48
@artem-harbour artem-harbour requested a review from a team as a code owner May 19, 2026 13:48
@artem-harbour artem-harbour requested a review from caio-pizzol May 19, 2026 13:48
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 959331bcbe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants