fix(ci): Change runner to ubuntu-slim for matrix#20623
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether other jobs in this workflow (or related workflows) should also be switched to
ubuntu-slimfor consistency in environment and performance characteristics, or document why this particular job is different. - Since
ubuntu-slimis a preview 1-vCPU runner, double-check that all tools and system dependencies used by this job are available there; if any steps rely on preinstalled software fromubuntu-latest, you may need explicit setup steps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether other jobs in this workflow (or related workflows) should also be switched to `ubuntu-slim` for consistency in environment and performance characteristics, or document why this particular job is different.
- Since `ubuntu-slim` is a preview 1-vCPU runner, double-check that all tools and system dependencies used by this job are available there; if any steps rely on preinstalled software from `ubuntu-latest`, you may need explicit setup steps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesCI Runner Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🚀 Build Images ReadyImages are ready for commit 753b7e3. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-995-g753b7e3830 |
davdhacs
left a comment
There was a problem hiding this comment.
great idea! I wonder if there are other jobs we could put onto 1core -slim runners? This alone would help us to reduce our concurrency and be able to run more at once.
Description
User-facing documentation
Testing and quality
Automated testing
CI