Skip to content

p-token: Expand comments#152

Merged
febo merged 1 commit into
mainfrom
febo/update-comments
May 11, 2026
Merged

p-token: Expand comments#152
febo merged 1 commit into
mainfrom
febo/update-comments

Conversation

@febo
Copy link
Copy Markdown
Contributor

@febo febo commented May 11, 2026

Problem

The last round of audit suggested to clarify aspects of the implementation:

  • TokenError: unused error variant
  • TokenInstruction::Batch and TokenInstruction::SetAuthority behaviour
  • inner_process_instruction: stale comment

Solution

Add clarifying comments for the above points.

@febo febo requested a review from joncinque May 11, 2026 14:48
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@febo febo merged commit 2c1b6ee into main May 11, 2026
29 checks passed
@febo febo deleted the febo/update-comments branch May 11, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants