Skip to content

fix(diagnosis): stop flagging client_id as prohibited inline PAR param#61

Merged
ryanbas21 merged 1 commit into
mainfrom
fix/par-inline-params-rule
May 15, 2026
Merged

fix(diagnosis): stop flagging client_id as prohibited inline PAR param#61
ryanbas21 merged 1 commit into
mainfrom
fix/par-inline-params-rule

Conversation

@ryanbas21
Copy link
Copy Markdown
Owner

Summary

  • The par:inline-params-with-request-uri diagnosis rule incorrectly treated client_id as a prohibited inline parameter in PAR authorization requests
  • Per RFC 9126, client_id is required alongside request_uri — only params like redirect_uri and scope should be flagged
  • Added test confirming a valid request_uri + client_id authorize URL does not trigger the warning

Test plan

  • Existing test (flags inline params alongside request_uri) still passes — redirect_uri in the URL correctly triggers the warning
  • New test (does not flag request_uri with only client_id) confirms the false positive is gone
  • Full diagnosis-engine test suite passes (41 tests)

🤖 Generated with Claude Code

Per RFC 9126, client_id is required alongside request_uri in the
authorization request after a Pushed Authorization Request. The
par:inline-params-with-request-uri rule incorrectly included client_id
in its check, causing false positives on valid PAR flows.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found.

TL;DR — Fixes a false positive in the par:inline-params-with-request-uri diagnosis rule where client_id was incorrectly flagged as a prohibited inline parameter alongside request_uri. Per RFC 9126, client_id is required in that context.

Key changes

  • Remove client_id from prohibited inline PAR params — The hasInlineParams check now only flags redirect_uri and scope, aligning the code with its own existing description ("only request_uri and client_id should be present") and RFC 9126.
  • Add regression test — Confirms request_uri + client_id alone does not trigger the warning, while existing test still validates that redirect_uri alongside request_uri is caught.

Summary | 3 files | 1 commit | base: mainfix/par-inline-params-rule

The change is correct, consistent with the existing error description, and well-tested. The test suite passes (the unrelated message-handler.test.ts failure is a pre-existing build resolution issue).

Pullfrog  | View workflow run𝕏

@ryanbas21 ryanbas21 merged commit 1c8688f into main May 15, 2026
1 check passed
@ryanbas21 ryanbas21 deleted the fix/par-inline-params-rule branch May 15, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant