test: enhance e2e diagnostics for tenant readiness failures#127
test: enhance e2e diagnostics for tenant readiness failures#127GatewayJ wants to merge 2 commits into
Conversation
- enrich live e2e snapshot with tenant/PV/pod logs for startup issues\n- add explicit snapshot diagnosis for erasure read quorum and DNS lookup failures\n- print diagnosis + artifact path directly in smoke and cert TLS failure paths\n- harden kind storage cleanup checks for non-empty/leftover host dirs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5526485995
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(tls_status) = tls_plan.status { | ||
| builder.set_tls_status(tls_status); | ||
| } |
There was a problem hiding this comment.
Clear TLS status when TLS is disabled
When spec.tls is removed or switched to Disabled, tls_plan.status is None and this branch skips any update to TLS fields, but StatusBuilder::from_tenant starts from the previous status snapshot. That leaves stale status.certificates.tls (and its old hash/error context) visible after TLS is turned off, which can mislead console/API consumers and automation that read tenant status. Please explicitly clear TLS status/condition when the plan is disabled.
Useful? React with 👍 / 👎.
Type of Change
Related Issues
N/A
Summary of Changes
diagnosis.txt) and structured return values for easier failure handling.erasure read quorumand DNS lookup failures, with recovery guidance.KindClustercleanup/create flow, add explicit host storage directory checks:Checklist
make pre-commit[Unreleased](if user-visible change)Impact
Verification
make pre-commit cargo test --manifest-path e2e/Cargo.toml -- --quiet cargo fmt --manifest-path e2e/Cargo.toml --check cargo clippy --manifest-path e2e/Cargo.toml --all-targets -- -D warningsAdditional Notes