🔒 replace predictable temp dir with fs.mkdtemp in zip-entries#42
🔒 replace predictable temp dir with fs.mkdtemp in zip-entries#42sunnylqm wants to merge 1 commit into
Conversation
Co-authored-by: sunnylqm <615282+sunnylqm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 What: The
enumZipEntriesfunction insrc/utils/zip-entries.tspreviously used a predictable mechanism based onDate.now()combined with a static prefix to create temporary directories for extracting.hapcontents. This vulnerability has been fixed.🛡️ Solution: To mitigate this vulnerability, the fix leverages the secure
fs.mkdtemp()method (from thefs-extra/fs.promiseslibrary) which appends securely generated pseudo-random characters to the directory prefix. This guarantees directory name uniqueness and prevents prediction by malicious actors. Testing confirmed no regressions in functionality, formatting or performance with zip entry resolution.PR created automatically by Jules for task 16770242411467217764 started by @sunnylqm