Add SGOV, QQQM, VMO, ARKK Feed#20
Open
Siddharth2207 wants to merge 8 commits into
Open
Conversation
Contributor
WalkthroughAdded SGOV/USD Pyth price feed constants and resolution logic, updated tests and fork baseline for SGOV (and several additional equity feeds). Also applied small formatting tweaks to function-pointer declarations, updated CI workflow prelude steps, replaced an env-based deploy address with a constant, and edited .gitignore. ChangesSGOV Price Feed and Tests
Formatting, CI, and Deploy
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.gitignore:
- Line 3: Remove the .pre-commit-config.yaml entry from .gitignore so the shared
pre-commit configuration is tracked by the repository; locate the .gitignore
line that lists ".pre-commit-config.yaml" and delete that line (or stop ignoring
that specific filename) so the repository can update and version the pre-commit
hooks without requiring forced adds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 752a9c68-8075-4373-a43f-b52657239ad9
⛔ Files ignored due to path filters (2)
flake.lockis excluded by!**/*.locksrc/generated/PythWords.pointers.solis excluded by!**/generated/**
📒 Files selected for processing (8)
.gitignoresrc/abstract/PythExtern.solsrc/abstract/PythSubParser.solsrc/lib/pyth/LibPyth.soltest/lib/LibFork.soltest/src/lib/pyth/LibPyth.constants.t.soltest/src/lib/pyth/LibPyth.getPriceFeedId.t.soltest/src/lib/pyth/LibPyth.getPriceNoOlderThan.t.sol
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
script/Deploy.sol (1)
12-23:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd a bytecode existence guard for
METABOARD_ADDRESSbefore emitting metadata.On Line 18, the script trusts a fixed address without checking deployment presence. If that address is not deployed on a target network, metadata registration can fail or no-op unexpectedly. Add a hard fail before
emitForDescribedAddress.Suggested patch
- IMetaBoardV1_2 metaboard = IMetaBoardV1_2(METABOARD_ADDRESS); + if (METABOARD_ADDRESS.code.length == 0) { + revert("METABOARD_ADDRESS has no code"); + } + IMetaBoardV1_2 metaboard = IMetaBoardV1_2(METABOARD_ADDRESS);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/Deploy.sol` around lines 12 - 23, Add a bytecode-existence guard for METABOARD_ADDRESS in run(): after creating metaboard (IMetaBoardV1_2 metaboard = ...), check address(metaboard).code.length > 0 (or address(METABOARD_ADDRESS).code.length > 0) and revert/require with a clear message (e.g., "METABOARD not deployed on this network") if zero; only call LibDescribedByMeta.emitForDescribedAddress when the check passes so the script hard-fails instead of silently continuing when the address has no deployed bytecode.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/src/lib/pyth/LibPyth.getPriceNoOlderThan.t.sol`:
- Around line 401-409: Add a clear NatSpec/doc comment above the
PRICE_FEED_ID_EQUITY_US_SGOV_USD constant in LibPyth.sol explaining that the
SGOV Pyth feed can be up to ~48 hours stale (versus the usual 24h for equities)
due to T-bill/ETF weekend and market-closure behavior, and recommend downstream
callers use staleAfter >= 48 hours (or handle weekend/holiday gaps) when calling
functions like getPriceNoOlderThan; include the rationale (iShares 0-3 Month
Treasury Bond updates/market closures) and the concrete recommended minimum
window so callers don’t choose a sub-48h staleAfter and trigger on-chain
reverts.
---
Outside diff comments:
In `@script/Deploy.sol`:
- Around line 12-23: Add a bytecode-existence guard for METABOARD_ADDRESS in
run(): after creating metaboard (IMetaBoardV1_2 metaboard = ...), check
address(metaboard).code.length > 0 (or address(METABOARD_ADDRESS).code.length >
0) and revert/require with a clear message (e.g., "METABOARD not deployed on
this network") if zero; only call LibDescribedByMeta.emitForDescribedAddress
when the check passes so the script hard-fails instead of silently continuing
when the address has no deployed bytecode.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f0522882-ab88-4c9a-b779-39777bc14eab
⛔ Files ignored due to path filters (1)
src/generated/PythWords.pointers.solis excluded by!**/generated/**
📒 Files selected for processing (7)
.github/workflows/manual-sol-artifacts.yamlscript/Deploy.solsrc/lib/pyth/LibPyth.soltest/lib/LibFork.soltest/src/lib/pyth/LibPyth.constants.t.soltest/src/lib/pyth/LibPyth.getPriceFeedId.t.soltest/src/lib/pyth/LibPyth.getPriceNoOlderThan.t.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extend
rain.pythequity feed coverage by adding SGOV and additional ETF mappings so downstream consumers can resolve and read these symbols through the existing Pyth integration.What Changed
src/lib/pyth/LibPyth.solfor:EQUITY.US.SGOV/USDEQUITY.US.QQQM/USDEQUITY.US.VMO/USDEQUITY.US.ARKK/USDgetPriceNoOlderThanbehavior for the new feeds.Validation
test/src/lib/pyth/LibPyth.constants.t.soltest/src/lib/pyth/LibPyth.getPriceFeedId.t.soltest/src/lib/pyth/LibPyth.getPriceNoOlderThan.t.soltest/lib/LibFork.solfor deterministic feed checks.Checks
By submitting this for review, I'm confirming I've done the following: