Use explicit Never for type inference#21497
Open
ilevkivskyi wants to merge 1 commit into
Open
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandera (https://github.com/pandera-dev/pandera)
+ pandera/engines/pandas_engine.py:1050: error: List comprehension has incompatible type List[Timestamp]; expected List[Never] [misc]
+ pandera/engines/pandas_engine.py:1050: note: Error code "misc" not covered by "type: ignore[arg-type]" comment
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/indexes/test_indexes.py:1624: error: Unused "type: ignore" comment [unused-ignore]
+ tests/indexes/test_indexes.py:1624: error: List item 0 has incompatible type "int"; expected "Never" [list-item]
+ tests/indexes/test_indexes.py:1624: note: Error code "list-item" not covered by "type: ignore[arg-type]" comment
trio (https://github.com/python-trio/trio)
+ src/trio/_threads.py:360: error: Unused "type: ignore" comment [unused-ignore]
|
Member
Author
|
Change of error code in pandas/pandera is somewhat unfortunate, but it actually looks correct (e.g. overload in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20391
The problem became more prominent with type variables with defaults, so better be consistent.