Skip to content

gh-149879: Fix test_tarfile on Cygwin #149897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
May 15, 2026
+10 −2
Merged

gh-149879: Fix test_tarfile on Cygwin #149897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cb7011
gh-149879: Fix test_tarfile on Cygwin
vstinner May 15, 2026
2e68342
Fix also test_realpath_limit_attack()
vstinner May 15, 2026
22b4e78
Revert useless change
vstinner May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3205,7 +3205,11 @@ def root_is_uid_gid_0():
import pwd, grp
except ImportError:
return False
if pwd.getpwuid(0)[0] != 'root':
try:
if pwd.getpwuid(0)[0] != 'root':
return False
except KeyError:
# On Cygwin, there is no root user (uid 0)
return False
if grp.getgrgid(0)[0] != 'root':
return False
Expand Down Expand Up @@ -3985,6 +3989,9 @@ def test_realpath_limit_attack(self):
check_flag=False)):
if sys.platform == 'win32':
self.expect_exception((FileNotFoundError, FileExistsError))
elif sys.platform == 'cygwin':
exc = self.expect_exception(OSError)
self.assertEqual(exc.errno, errno.ELOOP)
elif self.raised_exception:
# Cannot symlink/hardlink: tarfile falls back to getmember()
self.expect_exception(KeyError)
Expand All @@ -4006,7 +4013,8 @@ def test_realpath_limit_attack(self):
# 206: ERROR_FILENAME_EXCED_RANGE
self.assertIn(exc.winerror, (3, 5, 206))
else:
self.assertEqual(exc.errno, errno.ENAMETOOLONG)
self.assertIn(exc.errno,
(errno.ENAMETOOLONG, errno.ELOOP))

@symlink_test
def test_parent_symlink2(self):
Expand Down
Loading