Skip to content

[Feature] Define job name on a per function bases#985

Draft
jan-janssen wants to merge 1 commit into
mainfrom
update_jobname
Draft

[Feature] Define job name on a per function bases#985
jan-janssen wants to merge 1 commit into
mainfrom
update_jobname

Conversation

@jan-janssen
Copy link
Copy Markdown
Member

@jan-janssen jan-janssen commented May 15, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved default job naming logic for task submission.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7516322-716d-413e-80fd-64f31f86967e

📥 Commits

Reviewing files that changed from the base of the PR and between 4a63cb1 and 082bf9f.

📒 Files selected for processing (1)
  • src/executorlib/task_scheduler/file/spawner_pysqa.py

📝 Walkthrough

Walkthrough

The pull request modifies the default job name derivation in the execute_with_pysqa function. When resource_dict does not contain a "job_name" entry, the job name is now extracted from the input file_name parameter instead of deriving it from the parent directory of the computed working directory.

Changes

Job name default derivation

Layer / File(s) Summary
Job name default assignment logic
src/executorlib/task_scheduler/file/spawner_pysqa.py
The default resource_dict["job_name"] is now derived from os.path.basename(file_name).split("_i.h5")[0] instead of using the parent directory name of cwd.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • pyiron/executorlib#483: Also modifies the execute_with_pysqa logic to change the default resource_dict["job_name"] assignment.

Poem

🐰 A file name whispers its tale so true,
No more searching directories through and through,
Split at _i.h5, the basename sings,
A job name derived from simpler things! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes adding per-function job name definition, which aligns with the actual change of modifying the default job_name derivation logic in the spawner.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_jobname

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jan-janssen jan-janssen marked this pull request as draft May 15, 2026 22:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.16%. Comparing base (4a63cb1) to head (082bf9f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          39       39           
  Lines        2092     2092           
=======================================
  Hits         1970     1970           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant