docs+schema: external-anchor cited-source field + README link + MSRV fix (REQ-066/070)#306
Merged
Conversation
…, MSRV doc fix
Wave 1 / PR-B of the cross-git investigation follow-ups (FEAT-135).
Three small, low-risk fixes bundled — no code changes.
REQ-066 — `external-anchor` schema declares `cited-source`.
Every `external-anchor` artifact carrying a `cited-source` (the
field `rivet supplier pull` needs) emitted a spurious
`field 'cited-source' is not defined in schema for type
'external-anchor'` INFO at validate time — the artifact type built
for federation did not declare the field that makes it functional.
One field added to `schemas/common.yaml`. Verified: an
external-anchor with a cited-source no longer emits the INFO.
REQ-070 — README links docs/rivet-is-not.md above the first
user-action heading.
Per the First-Time User persona ("put it in the README, not three
clicks deep"). A blockquote before `## Install` points at the
SEooC "What Rivet is not" doc.
MSRV doc fix (from the docs audit, DOC-DOCS-AUDIT-2026-05-19).
`docs/srs.md` and `docs/verification.md` said MSRV 1.85;
`Cargo.toml` pins 1.89. Both docs corrected.
Verified: `rivet docs check` PASS (57 files, 0 violations);
binary rebuilds clean with the schema change.
Implements: REQ-010
Verifies: REQ-066
Refs: FEAT-135, REQ-070
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
📐 Rivet artifact deltaNo artifact changes in this PR. Code-only changes (renderer, CLI wiring, tests) don't touch the artifact graph. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 1 / PR-B of the cross-git investigation follow-ups (FEAT-135).
Three small, low-risk fixes bundled — no code changes.
external-anchorschema declarescited-source. Theartifact type built for federation didn't declare the field that
makes it functional, so every
external-anchorwith acited-sourceemitted a spuriousfield 'cited-source' is not definedINFO. One field added toschemas/common.yaml.docs/rivet-is-not.mdabove the firstuser-action heading (
## Install), per the First-Time Userpersona's "put it in the README, not three clicks deep."
DOC-DOCS-AUDIT-2026-05-19) —srs.mdandverification.mdsaid MSRV 1.85;Cargo.tomlpins 1.89.Test plan
external-anchorcarrying acited-sourceno longer emits the undefined-field INFO atrivet validate.rivet docs check— PASS (57 files, 0 violations).Implements: REQ-010
Verifies: REQ-066
Refs: FEAT-135, REQ-070
🤖 Generated with Claude Code