Conversation
The previous quit-time install flow piped installer output into an internal read-only modal. That worked for fully non-interactive scripts, but any command needing stdin (most importantly sudo's password prompt) would either silently fail or hang because the spawned child has no TTY. Replace the internal log dialog with an external terminal emulator (gnome-terminal -> konsole -> xterm -> x-terminal-emulator probe). The terminal becomes the install UI: sudo and other interactive prompts work natively, the user sees full coloured output, and the script can pause on a "Press Enter to close..." line before exit. quitTimeAppUpdateHandler is now minimal — call launchLinuxUpdater, emit a 'launched' metric on success, and on launch failure show a blocking error dialog (UPDATE_FAILED_TITLE + the error message + a "visit site" link). The blocking dialog both surfaces the failure to the user and gives the async Metrics.countEvent + logger.reportError calls time to flush before Phoenix exits. Drop the now-unused MAX_LOG_LINES const and the in-app log buffer.
abose
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.