Skip to content

[ENHANCEMENT] add client package#137

Open
shahrokni wants to merge 1 commit into
mainfrom
feat/create-client
Open

[ENHANCEMENT] add client package#137
shahrokni wants to merge 1 commit into
mainfrom
feat/create-client

Conversation

@shahrokni
Copy link
Copy Markdown
Contributor

@shahrokni shahrokni commented May 20, 2026

Description

Adds the client package and removes the remaining core dependencies.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@shahrokni shahrokni force-pushed the feat/create-client branch 3 times, most recently from 2fdb008 to 32b6a75 Compare May 21, 2026 09:11
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the feat/create-client branch from 39f0887 to b77d72b Compare May 21, 2026 10:03
Comment on lines +74 to +76
export interface ContentWithLegendLayoutOpts extends Required<
Omit<ContentWithLegendProps, 'children' | 'legendProps'>
> {
Copy link
Copy Markdown
Contributor Author

@shahrokni shahrokni May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My linter was throwing an exception forcing me to break the line! Has it been the case for anyone recently?, probably this should not happen?!

@shahrokni shahrokni marked this pull request as ready for review May 21, 2026 10:05
@shahrokni shahrokni requested a review from a team as a code owner May 21, 2026 10:05
@shahrokni shahrokni requested review from jgbernalp and removed request for a team May 21, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant