feat(ecs): support assign_public_ip in vpc_config for public Fargate clusters#104
Open
Will Graham (wlggraham) wants to merge 1 commit into
Open
feat(ecs): support assign_public_ip in vpc_config for public Fargate clusters#104Will Graham (wlggraham) wants to merge 1 commit into
Will Graham (wlggraham) wants to merge 1 commit into
Conversation
…clusters Add AssignPublicIp field to vpcConfig so clusters can opt in to public IP assignment via assign_public_ip: true in their cluster context. Defaults to disabled to preserve existing behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assign_public_ipboolean field to thevpcConfigstruct in the ECS plugintrue, tasks are launched withAssignPublicIp: ENABLED; defaults toDISABLED(no behavior change for existing clusters)Test plan
ecs-fargate-0.0.1) still work with no config changeecs-fargate-public-0.0.1cluster in heimdall-config and confirm the task gets a public IP and can pull the ECR image🤖 Generated with Claude Code