Skip to content

🌱 Bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0#2709

Open
tmshort wants to merge 2 commits into
operator-framework:mainfrom
tmshort:fix-semver
Open

🌱 Bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0#2709
tmshort wants to merge 2 commits into
operator-framework:mainfrom
tmshort:fix-semver

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented May 15, 2026

Bumps github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0.

Alternative to #2708

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

dependabot Bot and others added 2 commits May 15, 2026 14:50
Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/Masterminds/semver/releases)
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md)
- [Commits](Masterminds/semver@v3.4.0...v3.5.0)

---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
  dependency-version: 3.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Masterminds/semver v3.5.0 changed constraint error messages to quote the
invalid constraint value: "foobar" instead of foobar.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Copilot AI review requested due to automatic review settings May 15, 2026 20:45
@openshift-ci openshift-ci Bot requested review from ankitathomas and pedjak May 15, 2026 20:45
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 413f8f9
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a0785d3a0ade50008e7ed12
😎 Deploy Preview https://deploy-preview-2709--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the main module dependency on github.com/Masterminds/semver/v3 from v3.4.0 to v3.5.0 and adjusts the affected resolver test expectation for the library’s updated constraint error formatting.

Changes:

  • Bumped github.com/Masterminds/semver/v3 in go.mod.
  • Updated corresponding checksums in go.sum.
  • Updated one test assertion to match the new error message text.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
go.mod Updates the direct semver/v3 dependency to v3.5.0.
go.sum Updates module checksums for semver/v3 v3.5.0.
internal/operator-controller/resolve/catalog_test.go Adjusts the invalid version range error assertion for the new dependency behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rashmigottipati
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.12%. Comparing base (9b8b437) to head (413f8f9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
- Coverage   68.24%   68.12%   -0.13%     
==========================================
  Files         145      145              
  Lines       10698    10698              
==========================================
- Hits         7301     7288      -13     
- Misses       2869     2880      +11     
- Partials      528      530       +2     
Flag Coverage Δ
e2e 37.15% <ø> (-0.16%) ⬇️
experimental-e2e 52.69% <ø> (-0.20%) ⬇️
unit 53.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants