Skip to content

Adding ROSA Gap Analysis jobs to rosa-stage#3544

Open
ravitri wants to merge 1 commit into
openshift:mainfrom
ravitri:add-gap-rosa
Open

Adding ROSA Gap Analysis jobs to rosa-stage#3544
ravitri wants to merge 1 commit into
openshift:mainfrom
ravitri:add-gap-rosa

Conversation

@ravitri
Copy link
Copy Markdown
Member

@ravitri ravitri commented May 20, 2026

Creating this PR to add the list of *rosa-gap-analysis* jobs to rosa-stage.

cc @dustman9000 @bmeng

Reference - SREP-4310

Summary by CodeRabbit

  • Chores
    • Updated OpenShift configuration to recognize additional periodic CI job patterns.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Walkthrough

A new regex pattern for ROSA gap-analysis periodic CI jobs is added to the existing job name matching list in config/openshift.yaml. This extends the configuration to recognize and process additional periodic-ci job identifiers.

Changes

CI Job Pattern Configuration

Layer / File(s) Summary
Add ROSA gap-analysis job pattern
config/openshift.yaml
A new regex pattern ^periodic-ci-openshift-online-rosa-gap-analysis-main.* is added to the job matching list to recognize periodic-ci ROSA gap-analysis jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Sql Injection Prevention ❌ Error New file database_query.py executes SQL queries directly via cursor.execute(query) without parameterized queries or placeholders, violating SQL injection prevention requirements. Use parameterized queries with placeholders (cursor.execute with %s parameters) instead of direct query execution at line 556.
Go Error Handling ⚠️ Warning 22 ignored errors without justification, 211/333 fmt.Errorf calls missing %w wrapping, and 20 panic() calls outside init(). Document ignored errors with comments, use fmt.Errorf with %w for wrapping, replace panic() with proper error returns except in init/fatal paths.
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding ROSA Gap Analysis jobs to rosa-stage configuration by extending regex patterns in the openshift.yaml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Excessive Css In React Should Use Styles ✅ Passed PR only modifies config/openshift.yaml (Prow CI configuration), containing no React components or CSS code, making this React styling check not applicable.
Test Coverage For New Features ✅ Passed Configuration-only change: PR adds a new regex pattern to a generated YAML config file, not functional code. Existing tests cover regex matching logic already.
Single Responsibility And Clear Naming ✅ Passed The PR adds a well-named regex pattern to rosa-stage configuration. Naming is clear and specific, follows conventions, and maintains single responsibility throughout the structure.
Stable And Deterministic Test Names ✅ Passed PR modifies only config/openshift.yaml to add a regex job pattern. No Ginkgo test files or test code were changed, making this check not applicable.
Test Structure And Quality ✅ Passed The custom check requires review of Ginkgo test code, but this PR contains only standard Go unit tests (testing.T), not Ginkgo BDD tests. The check is not applicable.
Microshift Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests. It only modifies config/openshift.yaml to add a CI job pattern, making the MicroShift test compatibility check inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only YAML configuration changes (regex pattern for ROSA gap analysis jobs), not new Ginkgo e2e tests. Custom check for SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Change adds only a CI job pattern to config/openshift.yaml—no deployment manifests, operator code, controllers, or scheduling constraints. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies config/openshift.yaml with a regex pattern addition. OTE Binary Stdout Contract check applies to Go binaries and process-level code, not configuration files. Not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies config/openshift.yaml to add a regex pattern for tracking CI jobs. No Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check is not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dgoodwin and stbenjam May 20, 2026 08:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ravitri
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@ravitri: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant