OCPNODE-4125: Promote disruptive longrunning jobs to standard tier for component readiness

[QiWang19]

Summary by CodeRabbit

• Chores
  • Updated job-tier classifications to recognize and prioritize disruptive long-running jobs, assigning tech-preview and standard tiers as appropriate.
  • Bulk-adjusted many job entries from hidden to candidate or standard to improve scheduling visibility and resource handling.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6f5beb8e-f0e9-4187-8f7c-d30b987b5ae6

📥 Commits

Reviewing files that changed from the base of the PR and between aa3cad4 and a5f8d11.

📒 Files selected for processing (2)

• pkg/variantregistry/ocp.go
• pkg/variantregistry/snapshot.yaml

---

Walkthrough

This PR adds a job-tier classification rule for disruptive-longrunning jobs and updates the variant registry snapshot accordingly. A new pattern matching rule categorizes jobs containing -disruptive-longrunning as standard tier, followed by bulk snapshot updates reclassifying many configuration entries from hidden to standard or candidate tiers.

Changes

Job-tier pattern and snapshot updates

Layer / File(s)	Summary
Job-tier pattern rule for disruptive-longrunning jobs pkg/variantregistry/ocp.go	A new pattern rule in setJobTier matches jobs with -disruptive-longrunning and assigns them the standard component readiness tier.
Snapshot data tier reclassification pkg/variantregistry/snapshot.yaml	The snapshot is updated across 20 sections, reclassifying JobTier from hidden to standard in most entries and to candidate in specific sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 16 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Coverage For New Features	⚠️ Warning	PR adds new pattern matching functionality to setJobTier function but lacks test coverage. The function is pure with no external dependencies and should have tests per requirements.	Add test cases to TestVariantSyncer for the new disruptive-longrunning patterns. Consider adding test cases for existing disruptive patterns too (e2e-*-mco-disruptive).

✅ Passed checks (16 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically describes the main change: promoting disruptive longrunning jobs to the standard tier, which directly aligns with the modifications in both the code (job-tier patterns) and snapshot configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR adds two job tier pattern entries with no error handling violations. Functions called only use stdlib functions without error returns.
Sql Injection Prevention	✅ Passed	PR modifies job tier patterns and YAML config. No SQL queries are constructed or modified. Changes are unrelated to SQL injection.
Excessive Css In React Should Use Styles	✅ Passed	React components follow best practices: useStyles() hooks are used for styling, inline CSS is minimal (1-2 properties). No excessive inline CSS violations found.
Single Responsibility And Clear Naming	✅ Passed	PR adds two specific job tier patterns to existing method. Uses clear naming, maintains single responsibility, introduces no generic naming. Code organization remains cohesive.
Stable And Deterministic Test Names	✅ Passed	PR modifies only configuration files (ocp.go and snapshot.yaml), not test files. Repository uses standard Go testing, not Ginkgo. No test names to validate.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code is not applicable. PR contains 52 test files using Go's testing.T framework with testify, not Ginkgo.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests added. PR modifies job tier classification logic and configuration data only. Check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR modifies job tier classification in variant registry only. All test files are standard Go unit tests, not e2e. Check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies job tier classifications in Sippy, a CI test result analysis tool. No deployment manifests, operator code, or Kubernetes scheduling constraints are added or modified.
Ote Binary Stdout Contract	✅ Passed	This PR modifies Sippy (a prow job analysis tool), not an OTE binary. Changes are purely configuration updates to the setJobTier() function patterns with no stdout writes in process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. Changes are configuration-only: job tier patterns in ocp.go and JobTier values in snapshot.yaml. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci-robot]

@QiWang19: This pull request references OCPNODE-4125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

• Chores
• Updated job tier classifications across platform components to optimize resource management and improve scheduling of disruptive long-running jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

After openshift/origin#31185 fixes the current failure of disruptive-longrunning jobs, will trigger several runs to confirm these jobs are stable to promote the jobTier.

[ngopalak-redhat]

@QiWang19

1. Add links to prove that tests are passing stable for both regular and techpreview jobs
2. The process: If there is a failure, who will track it and how node team will be notified. I think this should be automated and some slack or email notification should come to node team members.

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.