ci(go-test): skip coverage upload on fork PRs#4255
Open
reinkrul wants to merge 1 commit into
Open
Conversation
GitHub strips id-token: write from workflow runs triggered by pull_request from a forked repository, so qlty-action's OIDC upload fails with "Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable" and the whole job goes red for external contributors. Gate the upload step on push events and same-repo PRs. Tests still run on fork PRs; coverage is still uploaded authoritatively on push to master / V* branches. Assisted by AI
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id-token: writeto cross-repository runs, soqlty-action's OIDC upload errors withUnable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable— turning the whole job red for external contributors (e.g. fix(vcr/verifier): handle unparseable issuer DID instead of nil deref #4247, run 25824280714).pushevents and same-repo PRs. Tests still run on fork PRs; coverage continues to upload on push tomaster/V*and on internal PRs.Test plan
masterstill uploads coverage to Qlty.Assisted by AI