📚❌ Add copy/delete row actions#2456
Open
AndyScherzinger wants to merge 7 commits into
Open
Conversation
2ad3024 to
6ad4928
Compare
enjeck
reviewed
Apr 11, 2026
a2ee2c1 to
cbd28cd
Compare
cbd28cd to
8d3df9d
Compare
24c8c07 to
112f0b4
Compare
5 tasks
Contributor
I closed #2456. I think this is better. Also safer around unique/mandatory/read-only fields than #1713’s immediate backend insert |
112f0b4 to
4348a57
Compare
Member
Author
|
I rebased the PR and fixed the conflicts, still need to do a round of testing on latest rebase 👍 |
Member
Author
|
Tested various column types/unique/default etc. and works for me 👍 |
enjeck
reviewed
May 15, 2026
0b9d9f4 to
5ee587c
Compare
5ee587c to
3d97e04
Compare
enjeck
requested changes
May 17, 2026
Contributor
enjeck
left a comment
There was a problem hiding this comment.
the row actions do not work for me on publicly shared tables.
Delete doesn't work in smartpicker
Contributor
|
...changing the action button to a 3-dot menu AI-assistant: Claude Code v2.1.101 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.101 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.126 (Claude Sonnet 4.6) AI-assistant: Claude Code v2.1.126 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…bedded tables AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…sync import guard ef3db38 tightened the userId guard in RowService::create() and ::updateSet() from `=== null` to `=== null || === ''` to prevent async import background jobs from silently creating rows without a real user in context. However, the codebase intentionally uses an empty string as the public-context sentinel: PublicRowOCSController calls setPublicContext(), which sets $this->userId = '' in SuperService and $isPublicContext = true in PermissionsService. PermissionsService::basisCheck() explicitly handles $userId === '' by returning true when isPublicContext is set. The tightened guard in ef3db38 rejected '' before it ever reached the permissions layer, breaking row create and update for all public link shares. The fix tracks the public context flag in SuperService itself via a new $isPublicContext property, set alongside $this->userId = '' in setPublicContext(). The guard in RowService is updated to: null → always throws (DI never injected a user) '' + !publicCtx → throws (background job running without a user — the case ef3db38 was protecting against) '' + publicCtx → passes (setPublicContext() was called intentionally) 'alice' → always passes (normal authenticated user) Async imports remain protected because ImportTableJob never calls setPublicContext(), so $isPublicContext stays false for that code path. AI-assistant: Claude Code v2.1.143 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
3d97e04 to
009d6f7
Compare
Member
Author
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.