Skip to content

feat(circle-details): allow setting avatar image for circle#5293

Draft
cristianscheid wants to merge 2 commits into
mainfrom
feat/2433/circle-preview-avatar
Draft

feat(circle-details): allow setting avatar image for circle#5293
cristianscheid wants to merge 2 commits into
mainfrom
feat/2433/circle-preview-avatar

Conversation

@cristianscheid
Copy link
Copy Markdown
Member

@cristianscheid cristianscheid commented Apr 30, 2026

Summary

  • Adds support for setting avatar image for circle

Screenshots

Screenshot from 2026-05-12 07-15-12 Screenshot from 2026-05-12 07-15-21
Screenshot from 2026-05-12 07-15-34 Screenshot from 2026-05-12 07-15-44
demo.webm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CircleDetails.vue 0.00% 91 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cristianscheid cristianscheid force-pushed the feat/2433/circle-preview-avatar branch from 2a114c1 to eb90eef Compare May 4, 2026 14:16
@cristianscheid
Copy link
Copy Markdown
Member Author

cristianscheid commented May 4, 2026

@kra-mo following your suggestion:

I positioned the avatar buttons beneath the name and description in edit mode and styled them closer to the reference in this issue. The PR description has been updated with screenshots and a short video showing the current state.

Two questions I'd appreciate your input on:

  1. How should we handle the button widths?
  2. Right now, selecting an image opens the cropper and clicking "Set as team picture" saves immediately to the backend. Should it instead only save when the main edit mode "Save" button is clicked?

Besides that, I'm also aware that probably a spacing between the buttons is needed and also some margin from the main edit mode "Cancel" and "Save" buttons. Just waiting for another round of input before moving forward.

Any other thoughts are welcome :)

@cristianscheid cristianscheid force-pushed the feat/2433/circle-preview-avatar branch from eb90eef to a5892d4 Compare May 4, 2026 17:06
@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented May 11, 2026

How should we handle the button widths?

The widths should definitely be homogeneous.

They should also have margins between them.

Right now, selecting an image opens the cropper and clicking "Set as team picture" saves immediately to the backend. Should it instead only save when the main edit mode "Save" button is clicked?

Since there is a "Cancel" button, the second behavior makes more sense.

@cristianscheid cristianscheid force-pushed the feat/2433/circle-preview-avatar branch 5 times, most recently from 927fa24 to a7b202b Compare May 12, 2026 11:09
@cristianscheid
Copy link
Copy Markdown
Member Author

cristianscheid commented May 12, 2026

@kra-mo thanks for the input, really appreciated! I've adopted your suggestions and updated the implementation. Also updated the main comment of this PR with new screenshots and a short video demoing the current state.

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the feat/2433/circle-preview-avatar branch from a7b202b to ccadcf6 Compare May 12, 2026 13:47
@cristianscheid cristianscheid self-assigned this May 13, 2026
@cristianscheid cristianscheid added enhancement New feature or request 2. developing Work in progress labels May 13, 2026
Comment thread src/components/CircleDetails.vue
Comment thread src/components/CircleDetails.vue Outdated
Comment thread src/components/CircleDetails.vue Outdated
Comment thread src/components/CircleDetails.vue Outdated
Comment thread src/components/CircleDetails.vue
Comment thread src/components/CircleDetails.vue
Comment thread src/components/CircleDetails.vue Outdated
…ing when saving/deleting avatar

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the feat/2433/circle-preview-avatar branch from 6bc1efc to 1893d10 Compare May 16, 2026 10:15
Copy link
Copy Markdown

@pringelmann pringelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support associating a "preview" picture to teams

3 participants