Skip to content

removed status of new#1277

Merged
janamakar merged 2 commits into
mainfrom
janamakar-patch-2
May 17, 2026
Merged

removed status of new#1277
janamakar merged 2 commits into
mainfrom
janamakar-patch-2

Conversation

@janamakar
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

Test deployment successful!! (2026-05-17T23:38:32Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/janamakar-patch-2

Seems the following pages differ;



See all deployed demo sites

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Ahoy! This patch attempts to clear the 'status' of the Slurm Job email announcement, but ye've left the empty key clutterin' up the manifest like a barnacle on a clean hull. The reviewer rightly notes that according to the ship's rules, if the status isn't 'new' or 'deprecated', the whole line must be scuttled entirely. Aside from this bit of laziness in the frontmatter, the change is straightforward.

Comment thread docs/Announcements/Slurm_Job_email.md Outdated
created_at: 2026-02-11
description: Email from Slurm Jobs now available
status: new
status:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Ahoy! I see ye've struck the 'new' status from the manifest, but ye've left the 'status' key itself bobbin' in the water like a piece of useless flotsam. If it's not 'new' and it's not 'deprecated', then it has no place on this ship. Scuttle the whole line, ye lazy scallywag, or are ye hopin' it'll grow a new value on its own? It's quite the achievement in laziness to leave such clutter in the manifest.

References
  1. The status parameter only allows 'new' or 'deprecated' as values. If neither applies, the field should be omitted. (link)

Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
@janamakar janamakar merged commit 068e894 into main May 17, 2026
8 checks passed
@janamakar janamakar deleted the janamakar-patch-2 branch May 17, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant