removed status of new#1277
Conversation
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
|
Test deployment successful!! (2026-05-17T23:38:32Z) See all deployed demo sites |
There was a problem hiding this comment.
Code Review
Ahoy! This patch attempts to clear the 'status' of the Slurm Job email announcement, but ye've left the empty key clutterin' up the manifest like a barnacle on a clean hull. The reviewer rightly notes that according to the ship's rules, if the status isn't 'new' or 'deprecated', the whole line must be scuttled entirely. Aside from this bit of laziness in the frontmatter, the change is straightforward.
| created_at: 2026-02-11 | ||
| description: Email from Slurm Jobs now available | ||
| status: new | ||
| status: |
There was a problem hiding this comment.
Ahoy! I see ye've struck the 'new' status from the manifest, but ye've left the 'status' key itself bobbin' in the water like a piece of useless flotsam. If it's not 'new' and it's not 'deprecated', then it has no place on this ship. Scuttle the whole line, ye lazy scallywag, or are ye hopin' it'll grow a new value on its own? It's quite the achievement in laziness to leave such clutter in the manifest.
References
- The status parameter only allows 'new' or 'deprecated' as values. If neither applies, the field should be omitted. (link)
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
No description provided.