fix: Combine portals + role-based sidebar navigation#34
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: Combine portals + role-based sidebar navigation#34devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Remove redundant pwa-products-showcase (standalone PWA) — all features already in customer-portal-full - Fix role-based permissions on 10 menu items that were incorrectly accessible to all roles: * USSD Gateway: canViewDashboard → canViewUserManagement (admin only) * NMID Integration: canViewPolicies → canViewUserManagement (admin only) * Insurance Technology: canViewPolicies → canViewAnalytics (admin/agent/underwriter) * Embedded Distribution: canViewPolicies → canViewCommission (admin/agent) * NIIRA 2025 Compulsory Insurance: canViewPolicies → canViewAuditLogs (admin/underwriter) * Claims Adjudication: canViewClaims → canViewPolicyApproval (admin/underwriter) * Renewal Automation: canViewPolicies → canViewUserManagement (admin only) * Multi-Currency: canViewPayments → canViewUserManagement (admin only) * Bank Integrations: canViewPayments → canViewUserManagement (admin only) * Smart Claim Routing: canViewClaims → canViewPolicyApproval (admin/underwriter) Role visibility: - Customer: 52 items (products, policies, claims, payments, profile) - Agent: 77 items (+ analytics, distribution, commissions) - Underwriter: 79 items (+ risk, fraud, compliance, actuarial) - Admin: 107 items (everything) Co-Authored-By: Patrick Munis <pmunis@gmail.com>
Author
Original prompt from Patrick
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
Removes the standalone
pwa-products-showcase/— a 674-line static HTML page that duplicated features already integrated intocustomer-portal-full. This was created in an earlier session as a temporary showcase and is now redundant.Fixes role-based sidebar permissions on 10 menu items that were incorrectly visible to roles that shouldn't see them. Previously, operational/admin tools like "Claims Adjudication", "USSD Gateway", "Bank Integrations", and "Renewal Automation" were visible to customers because they used overly permissive permission keys (
canViewClaims,canViewDashboard,canViewPolicies,canViewPayments).canViewDashboardcanViewUserManagementcanViewPoliciescanViewUserManagementcanViewPoliciescanViewAnalyticscanViewPoliciescanViewCommissioncanViewPoliciescanViewAuditLogscanViewClaimscanViewPolicyApprovalcanViewPoliciescanViewUserManagementcanViewPaymentscanViewUserManagementcanViewPaymentscanViewUserManagementcanViewClaimscanViewPolicyApprovalResulting visibility per role:
Review & Testing Checklist for Human
/claims-adjudication) can still navigate there directly. If route-level access control is needed, that requires additional work.Notes
RoleContext.tsx) was not modified — only thepermissionfield on individual menu items inUnifiedLayout.tsxwas updated.Link to Devin session: https://app.devin.ai/sessions/0475192a778b45cea30202f85ad52b63