Add readonly column types#42
Open
luarss wants to merge 2 commits into
Open
Conversation
Adds nine missing column types to the ColumnType enum (mirror, formula, board_relation, button, pulse_id, pulse_log, pulse_updated_value, subtasks) and a `is_readonly` / `is_writable` property pair that flags the 15 types which cannot be written via change_column_value / change_multiple_column_values mutations. The readonly set covers system-managed columns (creation_log, last_updated, auto_number, pulse_*, item_id), computed columns (mirror, formula, progress), UI-only columns (button), and columns that require a dedicated mutation rather than column_values (file, board_relation, dependency, subtasks). people/multiple-person/location are deliberately NOT marked readonly — they are writable via column_values but require specific JSON shapes (people IDs, lat/lng) rather than free-text input.
The category breakdown belongs in the PR description, not the code. Keep a one-line description and move the people/location/file exclusion note to a comment on the readonly set, which is where it's load-bearing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
is_readonly/is_writableproperties onColumnType, plusnine missing enum values (
MIRROR,FORMULA,BOARD_RELATION,BUTTON,SUBTASKS,PULSE_ID,PULSE_LOG,PULSE_UPDATED_VALUE,MULTIPLE_PERSON).is_readonlyisTruefor the 15 column types wherecolumn_valuesmutations are rejected by the API - system-managed, computed, UI-only,
or requiring a dedicated mutation (e.g.
file,board_relation).people,multiple-person, andlocationare intentionally notreadonly: they accept
column_valueswrites but require typedpayloads (people IDs, lat/long) rather than free text.
Scope
No internal calls consume the property yet.
Wiring it into write paths (e.g. raising before
change_multiple_column_values) reserved as a future TODO.