feat: Add new "Enabled" sorting button next to "Disabled"#6000
feat: Add new "Enabled" sorting button next to "Disabled"#6000NZ-Linix wants to merge 4 commits into
Conversation
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
We discussed this a bit and don't think we like the right click to toggle behavior, since basically no one will ever know that exists. I think the best solution for now is just to add an Enabled option next to the Disabled one. We may look into revamping the filtering experience a bit later down the line though. |
|
Of course. Should I work on implementing the new behaviour instead? |
|
sure, if you would like to! |
- When all mods are disabled, only "Disabled" shows - When all mods are enabled, only "Enabled" shows - When there disabled and enabled mods, then only both buttons show.
|
Alright, updated!
|
|
if all mods are enabled or all disabled, why would you need to filter for them? |
I just kept it like this because it is like this in the current version of the Modrinth App, If you'd like I can also change that up |
|
ah, yeah seems to be a bug. it should just show both of them if there is a mix, and neither otherwise |
3 participants
Requested by issue #5877 and #5682 (Two issues requested the same feature)
This adds a new button in the content page to filter mods by "Enabled" (next to already existing "Disabled").
If all mods are enabled, only the "Enabled" button appears. If all mods are disabled, only the "Disabled" button appears.
By default, only either "Disabled" or "Enabled" shows up (when there are disabled and enabled mods in a modpack). The user can right-click the button to switch between it (and then of course left click to toggle the filter). There is also a new setting in the settings menu under "Appearance" named "Content status filter buttons", which lets the user toggle between the right-click functionality or having both buttons always visible in the UI.
Everything described above has been tested and works.
Closes #5877
Closes #5682