Review/stories 1 1 and 1 2 patches#2
Merged
Conversation
- CHANGELOG: httpx2 constraint matches pyproject (>=2.0.0,<3.0); fix broken [Unreleased] compare link (HEAD...HEAD → commits/main). - pyproject: refactor [all] extra to self-reference siblings to prevent version drift. - README: document the [niquests] extra alongside [msgspec]/[otel]/[all]. - CI: drop duplicate --cov flag (addopts already injects --cov source). - Story 1.1 doc: fix File List header miscount (15 → 14); status → done. - New docs/deferred-work.md: log items intentionally deferred from this review (fork-PR codecov, just publish env-var guards, uv_build window, 3.14 wheel risk, unpinned ruff/ty, no [test] extra). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- response.py: Response.text falls back to UTF-8 when the declared
charset is unknown (wraps decode in try/except LookupError); class
docstring now documents `elapsed` as wall-clock seconds.
- tests: add quote-stripping coverage (charset="latin-1" / charset='latin-1'),
add UTF-8 fallback test for unknown charset, and tighten equality
tests with !=-against-variants for both Request and Response.
- Story 1.2 doc: AC8 typo ("frozen on all 4 dataclasses" → "all 5");
status → done.
- docs/deferred-work.md: log 10 items deferred from the review (charset
parser robustness, header/URL/with_* validation, Timeout/Limits guards,
multi-valued params, streaming bodies, json() charset, @Final).
Post-patch: just lint-ci clean, 27 tests pass (+3 new), 100% coverage
retained.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.