Fix G keep notes issues#8
Open
froston wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gkeep-parsersilently falls back tonew Date()when it can't parse the localized.headingtext. We now use the source file's last‑modified time (ZIP central‑directory date for archives,File.lastModifiedfor raw drops) as the authoritativecreated/updatedtimestamp.._keepextension were being rejected as an unknown format. They are now recognized as Google Keep alongside.html, so Takeout exports that ship._keepfiles import correctly.<updated>element and route every date through a safetoEnexDate()helper instead of inline string‑munging that assumed already‑ISO input.Changes
src/modules/worker.js: scan now reports each ZIP entry'slastModified; extract returns adateMapkeyed by path.src/main.js: threadcombinedDateMapfrom extraction →finishConversion, override each parsed note'screated/updatedwith the file date, addtoEnexDate()and emit<updated>in the ENEX output.src/config/formats.js:detectFormatnow recognizes._keepfiles as Google Keep.Test plan
.enexand confirm Apple Notes shows the original dates instead of today..htmlKeep notes; verifyFile.lastModifiedis used for the ENEX<created>timestamp.._keepfile (or a ZIP containing them) and confirm it's detected as Google Keep and converts successfully.