LPM ci integration#19
Merged
Merged
Conversation
To allow tests to install dependencies
Now we have it working with LPM_TOKEN lets try the standard Github Token
This is only needed if using GITHUB_TOKEN but we cant use that
sclaiborne
commented
May 8, 2026
There was a problem hiding this comment.
Pull request overview
This pull request updates the CI pipeline to test against newer Python versions and to provision the Node.js-based lpm tool that some tests use to generate the AsProject fixture.
Changes:
- Expanded the CI Python version matrix (dropping 3.10, adding 3.13 and 3.14).
- Added Node.js setup and a step to install
@loupeteam/lpmfrom GitHub Packages. - Adjusted test setup to invoke
lpmwith the-s(silent) flag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/conftest.py |
Updates how lpm is invoked when generating the AsProject test fixture. |
.github/workflows/ci.yml |
Updates Python matrix and installs/configures Node.js + lpm for CI runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+43
| - name: Install lpm | ||
| run: npm install -g @loupeteam/lpm@1.2.0 | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.LPM_TOKEN }} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request updates the CI workflow to support newer Python and Node.js versions, and adds installation steps for the
lpmpackage manager. These changes ensure compatibility with the latest Python releases and set up the environment for Node-based tooling.CI environment updates:
Node.js and tooling setup:
actions/setup-node@v4.@loupeteam/lpmpackage globally via npm, preparing the environment for workflows that depend on this tool.Why:
This will allow the full test range to be ran