Skip to content

Use --external-launcher for Slurm launch; fallback to old behavior; add srun wrapper CI job#178

Merged
nchaimov merged 3 commits into
llnl:develfrom
ParaToolsInc:pr58-rebased
May 15, 2026
Merged

Use --external-launcher for Slurm launch; fallback to old behavior; add srun wrapper CI job#178
nchaimov merged 3 commits into
llnl:develfrom
ParaToolsInc:pr58-rebased

Conversation

@nchaimov
Copy link
Copy Markdown
Collaborator

This contains the commit from #58, which uses --external-launcher with the Slurm srun wrapper, with the following changes:

  • Rebased on devel so that we have the CI tests in place.
  • Falls back to old behavior for Slurm before 23.11 (when --external-launcher was added).
  • Adds new CI job which builds Spindle with rm=slurm and without rshlaunch, in order to test the changed code.

Copy link
Copy Markdown
Member

@mplegendre mplegendre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure another CI set was necessary for just this mode. But since the work is already done, I'm not going to object either.

Otherwise looks good.

@nchaimov nchaimov merged commit 1514745 into llnl:devel May 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants