Strict type checking fixes#670
Open
lukasIO wants to merge 13 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
lukasIO
commented
May 18, 2026
| event.participant_encryption_status_changed.is_encrypted, | ||
| ) | ||
| elif which == "participant_permissions_changed": | ||
| elif which == "participant_permission_changed": |
Contributor
Author
There was a problem hiding this comment.
this appears to have been a real bug and not just a typing issue, but became apparent due to the strict type checking
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
lukasIO
commented
May 18, 2026
| FfiClient.instance.queue.unsubscribe(queue) | ||
|
|
||
| if cb.send_stream_chunk.error: | ||
| if cb.send_stream_trailer.error: |
Contributor
Author
There was a problem hiding this comment.
and another bug that devin spotted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#551 rebased on latest main