fix(extensions): accept 'ready' response as valid reply to load action#146
Open
bryanchua5327 wants to merge 1 commit into
Open
fix(extensions): accept 'ready' response as valid reply to load action#146bryanchua5327 wants to merge 1 commit into
bryanchua5327 wants to merge 1 commit into
Conversation
Some extensions (e.g. triposg) respond to the load action with a
'ready' message (including params_schema) rather than 'loaded'.
The load() method previously only accepted 'loaded', causing a
RuntimeError even though the extension had initialised successfully.
Accepting both 'ready' and 'loaded' as valid load responses fixes the
crash. The params_schema sent with a 'ready' reply is already captured
by _start(); handling it here is a no-op but keeps the contract clear.
Reproducer:
RuntimeError: [triposg/generate] Unexpected response to load:
{'type': 'ready', 'params_schema': [...]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some extensions (e.g. triposg) respond to the load action with a 'ready' message (including params_schema) rather than 'loaded'. The load() method previously only accepted 'loaded', causing a RuntimeError even though the extension had initialised successfully.
Accepting both 'ready' and 'loaded' as valid load responses fixes the crash. The params_schema sent with a 'ready' reply is already captured by _start(); handling it here is a no-op but keeps the contract clear.
Reproducer:
RuntimeError: [triposg/generate] Unexpected response to load:
{'type': 'ready', 'params_schema': [...]}