Fix protocol_transaction_out_106 loop ob1.#1007
Merged
Merged
Conversation
rsantacroce
pushed a commit
to rsantacroce/libbitcoin-node
that referenced
this pull request
May 17, 2026
Reviewer-confirmed corrections from evoskuil across 12 docs: - 02: milestone allows validation bypass (not chain-fixing); chaser_block skips milestones because blocks-first has no PoW DoS guard; debug-only checks are !NDEBUG; LRU eviction on tree_ would create a new DoS vector. - 03: get_inventory_size gates on candidate-chain currentness, with the weak-chain rationale (not "wait until caught up"). - 04: consensus is split across headers, block-receive, this chaser, and confirm; intro softened from "single source of consensus acceptance". - 05: !NDEBUG polarity fix; expanded block_confirmable to describe strong-tx association, maturity, and relative-locktime rules. - 06: session-template class diagram now shows all three instantiations; recent != current (max-height config for testing). - 08: superseded_ is atomic because superseded() is protected and read non-stranded from the base. - 09: unhandled channel messages are ignored, not protocol_violation. - 10: sub1/add1 was a real off-by-one bug, fixed in PR libbitcoin#1007. - 11: order-discipline is the same as headers-first; BIP130 typo fix. - 12: chaser_storage timer runs on the chaser's strand (network threadpool), not a separate pool. - 00, README: roll-up updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.