frontend: Event: Put hooks back into the class for compatibility#5656
Draft
sniok wants to merge 1 commit into
Draft
frontend: Event: Put hooks back into the class for compatibility#5656sniok wants to merge 1 commit into
sniok wants to merge 1 commit into
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sniok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
There was a problem hiding this comment.
Pull request overview
Restores useEventListForClusters and useEventWarningList as static members of the Event class so that they remain reachable via window.pluginLib.K8s.event.default, addressing the plugin API regression reported in #5652. Depends on #5655 being merged first to refresh the pluginLib snapshot.
Changes:
- Re-attach the two event hooks as static class members on
Event.
sniok
force-pushed
the
revert-events-methods-change
branch
from
2a02223 to
2932d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places hook back as static methods that were moved recently, addresses #5652
#5655 should be merged first, then this PR should be updated with new snapshot and only then merged.