check-edge-label: report missing target instead of panicking#623
Open
tamalsaha wants to merge 1 commit into
Open
check-edge-label: report missing target instead of panicking#623tamalsaha wants to merge 1 commit into
tamalsaha wants to merge 1 commit into
Conversation
LoadByGVK error was discarded and rdTarget then dereferenced on the next line, so the first dangling offshoot label aborted the entire check with a nil-pointer panic instead of listing every violation. Treat a missing/unregistered target as the violation it is: print a message, increment the error count, and continue scanning. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/check-edge-label/main.godiscarded theLoadByGVKerror and then dereferencedrdTarget.Spec.Resource.Scope. The first offshoot edge pointing to an unregistered target panicked the whole check, masking any subsequent violations.LoadByGVKreturns nil/err, and keep scanning.Test plan
go run ./cmd/check-edge-labelexits 0 against a clean tree (no offshoots with mismatched scope or missing targets)🤖 Generated with Claude Code