fix(core): make callbacks config optional#36
Open
vklimontovich wants to merge 2 commits into
Open
Conversation
Crash on `Nextlytics({ backends: [...] })` without `callbacks`:
`TypeError: Cannot read properties of undefined (reading 'getUser')`.
README and quickstart treat callbacks as optional, but the type required
it and `withDefaults` did not provide a default, so `server.tsx` and
`api-handler.ts` dereferenced `undefined`.
- Mark `callbacks` optional on `NextlyticsConfig`.
- Default it to `{}` in `withDefaults` so internal access stays simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nextlytics({ backends: [...] })withoutcallbackscrashed withTypeError: Cannot read properties of undefined (reading 'getUser')callbacksas optional, but the type required it andwithDefaultsdid not provide a default.server.tsxandapi-handler.tsdereferencedundefined.callbacksoptional onNextlyticsConfig, default it to{}inwithDefaults, and add a small regression test.Found while running an external e2e (Next 15 + Next 16 apps using
postgrestBackend) — events stopped landing in the destination until I addedcallbacks: {}to the config.Test plan
bun run typecheckpassesbun run testpasses (newconfig-helpers.test.tslocks the behavior)callbacksfield) — middleware now dispatches and events arrive at PostgREST