feat: add records-limit flags for json and ndjson#150
Open
lidel wants to merge 1 commit into
Open
Conversation
JSON delegated routing responses under-delivered: boxo applied the records limit before filtering, so records dropped by filters shrank the response below what callers asked for. The fix lives in boxo (ipfs/boxo#1157); someguy bumps to it and exposes the caps as configurable flags. - main.go: add --records-limit / SOMEGUY_RECORDS_LIMIT (100) and --streaming-records-limit / SOMEGUY_STREAMING_RECORDS_LIMIT (1000); reject negative values - server.go: wire both into server.WithRecordsLimit / WithStreamingRecordsLimit - go.mod: bump boxo to the post-filter records-limit commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON responses under-delivered: boxo applied the records limit before filtering, so records dropped by filters shrank the response below what callers asked for.
The fix lives in boxo:
Someguy bumps to it and exposes the caps as configurable flags.
Changes
Note
#149 and #150 fix the same bug two ways. Merge only one.
cachedRouterover-fetches 3x to offset records dropped for missing addresses, then caps the result. Self-contained, but 3x is a guess and the fix stays in someguy.filter-addrs/filter-protocolsunder-delivery for all consumers.Feedback welcome, but my gut feeling is the #150 is preferable: it fixes the root cause in the shared layer. Needs ipfs/boxo#1157 first.